feat(covenantsigner): HTTP issuer for SignerApprovalCertificate - #4235
Open
lionakhnazarov wants to merge 2 commits into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
lionakhnazarov
force-pushed
the
feat/signer-approval-cert-issuer
branch
2 times, most recently
from
August 7, 2026 09:37
15fe2ac to
43b0f7c
Compare
Operators need a production path to obtain the v2 threshold-signed permission slip that live Submit already requires. Wire the existing issueSignerApprovalCertificate path through POST /v1/admin/signer-approval-certificates on top of threshold-network#4169.
lionakhnazarov
force-pushed
the
feat/signer-approval-cert-issuer
branch
from
August 7, 2026 09:41
43b0f7c to
2cef4b1
Compare
…issuer - Gate POST /v1/admin/signer-approval-certificates behind a distinct AdminAuthToken; it no longer accepts the ordinary submit/poll token. - Require an authenticated ArtifactApprovals envelope (route/reserve/network scoped depositor+custodian trust roots) instead of a caller-asserted approvalDigest; the server verifies the approval and derives the digest itself before signing, mirroring the Submit path's authenticity check. - Bound certificate issuance by the same inFlightSlots semaphore Submit and Poll respect. - Map a busy signing executor to 503 + Retry-After instead of an opaque 500, and document that callers must use a client timeout >= submitTimeout since issuance has no retrieval path. - Fix decodeBytes20HexString's error message (it validated a Bitcoin wallet public-key hash but reported an Ethereum-style address error). - Rework and extend server_test.go coverage for the new contract: admin vs submit token isolation, forged-approval rejection, and full-field certificate assertions on the happy path. Add the missing engine-level ErrWalletNotFound regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /v1/admin/signer-approval-certificatesso operators can obtain a real v2SignerApprovalCertificatefor live Submit.issueSignerApprovalCertificate); request bindswalletPublicKeyHash+approvalDigest+endBlock(digest must match the job’s artifact-approval payload).Test plan
go test ./pkg/covenantsigner/ -run 'TestServerIssuesSignerApprovalCertificate|TestServerReturns501|TestServerRequiresBearerTokenForCertificateIssuer|TestServerRejectsUnknownFieldsOnCertificateIssuer|TestServerRejectsInvalidCertificateIssuerInput'go test ./pkg/tbtc/ -run 'TestCovenantSignerEngineIssueSignerApprovalCertificate'0x12b3fd…with a real VBA approval digest → Submit REDEEM → Poll; observe whether other ops join the signing roundMade with Cursor